No relative links into symlinked dirs #99
Conversation
|
Thanks for the PR. I will have to review this carefully later, but unless I find a regression will be happy to merge it. |
|
On my test project some symlinks that were previously relative symlinks and were not broken were replaced with absolute symlinks, so this is definitely a regression. This module uses the --basedir option so that may be a good place to start looking. |
|
Okay. Didn't used the setting yet. I'll look into it. I'll try to reproduce your issue later. But if you like, you could give me a sample project structure to test with. |
|
Modified the PR to fullfill some more cases. basedir should work fine now. Seems to work as expected on my live project too. |
|
Just ran a quick test and it is still creating absolute links in my projects where it should be using relative links. I will try to update your test repo sometime with a case that exhibits the issue. |
Example struct:
a/
b/
Without the patch the project will contain these two symlinks:
The patch will change 2nd symlink to an absolute symlink.
Before you judge: Yes that's not a good project structure. I agree. But this also applies to symlinks not created by modman and pointing out of the project root. You may still not like it, but it shouldn't break any existing setups, only support more bad cases.
Lets pray for Magento 2.0 to end that mess ;)